-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Zuul Logging job #113
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some pieces that should be taken out, I think.
I suggest you start by creating a new PR that just adds the common tasks in their own role.
After that, create a PR for the test_logging role (with Depends-On the common_task PR) and then the zuul job (you can reuse this PR) (with a Depends-On on the test_logging PR).
The job won't run on the first two PRs, but the test result from this PR (i.e. "the zuul PR") will be valid for both the "common_tasks PR" and the "test_logging role" PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made updates suggested and associated changes needed.
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/1b0c0c692c4b4ce5bd342521b556b123 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 27m 12s |
ci/logging_tests_ctlplane.yml
Outdated
changed_when: false | ||
|
||
|
||
- name: "RHOSO-12754" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, the custom_logger does not look at play names to find the test ids and therefore determine what to log.
It definitely looks at tasks.
The logger MIGHT look at blocks and report pass/fail if the block name has an ID in it.
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/c31500c78aa243329da4f5edb570f4c1 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 24m 57s |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/21a4344a3a7b40e2931b4eb1bce91314 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 41m 00s |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/177f9dd6e06547faabd000c2302ea3b2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 18s |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/32877f52508944ecb877af82800c0a98 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 58s |
made lots of changes and will submit new PR. |
Reopening for testing |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
I rebased this branch against master. |
76955cc
to
b302395
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f9cc04896a584e57b8dad887f4f161bf ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 22m 46s |
This change depends on a change that failed to merge. Change #118 is needed. |
recheck |
0799ffd
to
4156382
Compare
I rebased this against the branch for PR#118 to avoid Zuul complaining |
This change depends on a change that failed to merge. Change #118 is needed. |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5c83054825344e6b92fbca4cf36fbd82 ❌ openstack-k8s-operators-content-provider FAILURE in 6m 39s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3775baa77de04fbd9e173618a9f3814f ❌ openstack-k8s-operators-content-provider FAILURE in 9m 16s |
recheck |
I need to update this to get the logs in the right place. They are currently not showing, but I think that's because of the recently merged updates to the autoscaling tests that also updates the custom_logger and report-result . |
Add a job that runs the telemetry_logging and common roles against the openstack cloud. Separate plays target compute and control nodes
The logging plugins we use need all the tests to run in order to report properly. Adding ignore_errors to the plays that run the tests allows all the tests to run even when one fails. Also added verbosity to the ansible config to get more info about the failing tests
80f789a
to
3e94faf
Compare
039560d
to
0d409d2
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/aed3b61014404517aff7df849f4cd656 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 56m 12s |
|
||
pod_test_id: "RHOS0-12672" | ||
pod_status_str: "Running" | ||
pod_nspace: openstack-operators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the qe_common role, the corresponding tasks expect "ns" to be defined, not "pod_namespace"
This change depends on a change that failed to merge. Change #123 is needed. |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f2da3c9b316b4dd7bb1790f4b37c2f3c ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 26m 43s (elfiesmelfie): this failed due to a deployment failure, not a test failure |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f22267ec8e8a40be9c32e6b275a307d3 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 28m 18s |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c1209b7abab04e22bdd4ab1abf05ef02 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 20m 19s |
KUBECONFIG: "{{ cifmw_openshift_kubeconfig }}" | ||
PATH: "{{ cifmw_path }}" | ||
vars: | ||
pod_test_id: "RHOSO-12752" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the format for these vars should be updated to match the format used by the endpoints.
e.g.
[namespace,pod,status]
That way, multiple plays are not needed.
Same feedback applies to anything that has multiple namespaces
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/cc53c6c861da4c6dbab4a007a952f71b ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 16m 57s |
Merge Logging job changes into Master
Depends-On: #123
Depends-On: #124
#Depends-On: #118